Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work has been done together by the following people:
@savvadia
@vect0r-vicall
@picojulien
@johnyob
@raphael-proust
Motivation
cohttp
is not closing client-side connections on request in relay connections, which could lead to resource leak.Exposing the
close_fn
function is already present in the newerv6
version, so this addition we think is necessary as it allows finer resource management and is likely to be a backport of the feature fromv6
tov5
.Solution
cohttp
now exposesclose_fn
defined byCohttp_lwt.Client.call
. This callback should be used when a newly created connection should be closed, thanks to the newCohttp_lwt.Client.call_with_closefn
function.