feat(parser): Added Docker support with new parameter to define output path for exported files #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t path for exported files - **Dockerfile**: - Added new file Dockerfile for building Docker image. - **README.md**: - Added section for Docker - A usage of application updated to include new parameters `-p` and `--output-path`. - **app.ts**: - Added new variable `outputPath` to define the path of the output file. - Updated function for parsing input parameters to include the new parameters `-p` and `--output-path` with defined default value. - Updated `console.log` messages to include the new parameters. - Updated constant for calling a Chromium browser, including new arguments for launching browser in Docker container. - Updated calling `writeJson` and `writeCsv` functions to include the new `outputPath` parameter. - **write.ts**: - Function `writeJson`: Added new parameter `outputPath` to define the path of the output file. - Function `writeJson`: Updated constant `outFilename` where base path is defined by `outputPath` variable, not hard-coded anymore. - Function `writeCsv`: Added new parameter `outputPath` to define the path of the output file. - Function `writeCsv`: Updated constant `outFilename` where base path is defined by `outputPath` variable, not hard-coded anymore.
gabrielweyer
requested changes
Sep 21, 2024
… review suggestions from PR accepted and implemented - **Dockerfile**: - Fixed obsolete definition of ENVIROMENT variables to correct syntax. - Added source link for more information about depebdencies for Puppeteer respectivly Chromium/Chrome in Docker. - Dockerfiile moved to `parser` directory. - Updated path for `COPY` command. - Removed commented code for creataing a new user in Docker. This is not needed for the current implementation. - **README.md**: - Section for Docker updated with new instructions. - **app.ts**: - Variable `outputPath`: Default value is set to `./out`. Variable is now validated twice. - Variable `outputPath`: Always is checked if path exists. If not, it will be created. - Added source link for more information about calling Chrome/Chromium with `--no-sandbox` flag in Docker while running Puppeteer.
gabrielweyer
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(parser): Added Docker support with new parameter to define output path for exported files
Dockerfile:
README.md:
-pand--output-path.app.ts:
outputPathto define the path of the output file.-pand--output-pathwith defined default value.console.logmessages to include the new parameters.writeJsonandwriteCsvfunctions to include the newoutputPathparameter.write.ts:
writeJson: Added new parameteroutputPathto define the path of the output file.writeJson: Updated constantoutFilenamewhere base path is defined byoutputPathvariable, not hard-coded anymore.writeCsv: Added new parameteroutputPathto define the path of the output file.writeCsv: Updated constantoutFilenamewhere base path is defined byoutputPathvariable, not hard-coded anymore.