Remove GitHub Token from Build Display. Fixes issue #17 (#18)

- Removed GitHub Access Token from variable being displayed during build. Fixes Issue #17.
gaelcolas · Aug 31, 2021 · fa359c1 · fa359c1
1 parent d314a29
commit fa359c1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.build/tasks/New-Release.GitHub.build.ps1 b/.build/tasks/New-Release.GitHub.build.ps1
@@ -109,7 +109,10 @@ task Publish_release_to_GitHub -if ($GitHubToken -and (Get-Module -Name PowerShe
             ErrorAction    = 'Stop'
         }
 
-        Write-Build DarkGray "Checking if the Release exists: `r`n Get-GithubRelease $($getGHReleaseParams | Out-String)"
+        $displayGHReleaseParams = $getGHReleaseParams.Clone()
+        $displayGHReleaseParams['AccessToken'] = 'Redacted'
+
+        Write-Build DarkGray "Checking if the Release exists: `r`n Get-GithubRelease $($displayGHReleaseParams | Out-String)"
 
         try
         {

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Added logo.
 - Added Get-GHOwnerRepoFromRemoteUrl function.
 
+### Removed
+
+- Removed GitHub Access Token from variable being displayed during build. Fixes Issue #17.
+
 ### Changed
 
 - Fixed tasks to use the new Sampler version and its public functions.