Skip to content

Commit

Permalink
Prevent leading/trailing colons in path variables
Browse files Browse the repository at this point in the history
The previous version added leading and trailing colons to these values if a variable had no assigned value before the buildpack script ran.
  • Loading branch information
brian-kephart authored and nateberkopec committed Oct 3, 2017
1 parent 066c82e commit 48a8c80
Showing 1 changed file with 17 additions and 17 deletions.
34 changes: 17 additions & 17 deletions bin/compile
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@ function vendor() {
mkdir -p $path
curl -sL $binary -s -o - | tar xz -C $path -f -

[ -d "$path/bin" ] && export PATH=$path/bin:$PATH
export CPPPATH="$path/include:$CPPPATH"
export CPATH="$path/include:$CPATH"
export LIBRARY_PATH="$path/lib:$LIBRARY_PATH"
export LD_LIBRARY_PATH="$path/lib:$LD_LIBRARY_PATH"
[ -d "$path/lib/pkgconfig" ] && export PKG_CONFIG_PATH="$path/lib/pkgconfig:$PKG_CONFIG_PATH"
[ -d "$path/bin" ] && export PATH=$path/bin${PATH:+:${PATH}}
export CPPPATH="$path/include${CPPPATH:+:${CPPPATH}}"
export CPATH="$path/include${CPATH:+:${CPATH}}"
export LIBRARY_PATH="$path/lib${LIBRARY_PATH:+:${LIBRARY_PATH}}"
export LD_LIBRARY_PATH="$path/lib${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}"
[ -d "$path/lib/pkgconfig" ] && export PKG_CONFIG_PATH="$path/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"

true
}
Expand All @@ -40,22 +40,22 @@ vendor "https://github.com/mojodna/heroku-buildpack-jemalloc/releases/download/v
echo "-----> Configuring build environment"

cat <<EOF > export
export PATH="$PATH:\$PATH"
export LD_LIBRARY_PATH="\$LD_LIBRARY_PATH:$LD_LIBRARY_PATH"
export LIBRARY_PATH="\$LIBRARY_PATH:$LIBRARY_PATH"
export PKG_CONFIG_PATH="\$PKG_CONFIG_PATH:$PKG_CONFIG_PATH"
export CPPPATH="\$CPPPATH:$CPPPATH"
export CPATH="\$CPATH:$CPATH"
export PATH="${PATH:+${PATH}:}\$PATH"
export LD_LIBRARY_PATH="\$LD_LIBRARY_PATH${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}"
export LIBRARY_PATH="\$LIBRARY_PATH${LIBRARY_PATH:+:${LIBRARY_PATH}}"
export PKG_CONFIG_PATH="\$PKG_CONFIG_PATH${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
export CPPPATH="\$CPPPATH${CPPPATH:+:${CPPPATH}}"
export CPATH="\$CPATH${CPATH:+:${CPATH}}"
EOF

echo "-----> Building runtime environment"
mkdir -p $BUILD_DIR/.profile.d

cat <<EOF > $BUILD_DIR/.profile.d/$BUILDPACK_NAME.sh
export PATH="${PATH//$BUILD_DIR//app}:\$PATH"
export LD_LIBRARY_PATH="\$LD_LIBRARY_PATH:${LD_LIBRARY_PATH//$BUILD_DIR//app}"
export LIBRARY_PATH="\$LIBRARY_PATH:${LIBRARY_PATH//$BUILD_DIR//app}"
export PKG_CONFIG_PATH="\$PKG_CONFIG_PATH:${PKG_CONFIG_PATH//$BUILD_DIR//app}"
export CPPPATH="\$CPPPATH:${CPPPATH//$BUILD_DIR//app}"
export CPATH="\$CPATH:${CPATH//$BUILD_DIR//app}"
export LD_LIBRARY_PATH="\${LD_LIBRARY_PATH:+${LD_LIBRARY_PATH}:}${LD_LIBRARY_PATH//$BUILD_DIR//app}"
export LIBRARY_PATH="\${LIBRARY_PATH:+${LIBRARY_PATH}:}${LIBRARY_PATH//$BUILD_DIR//app}"
export PKG_CONFIG_PATH="\${PKG_CONFIG_PATH:+${PKG_CONFIG_PATH}:}${PKG_CONFIG_PATH//$BUILD_DIR//app}"
export CPPPATH="\${CPPPATH:+${CPPPATH}:}${CPPPATH//$BUILD_DIR//app}"
export CPATH="\${CPATH:+${CPATH}:}${CPATH//$BUILD_DIR//app}"
EOF

0 comments on commit 48a8c80

Please sign in to comment.