Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't reproduce Figure 3e #2

Open
Lulu0015 opened this issue Dec 12, 2024 · 3 comments
Open

Can't reproduce Figure 3e #2

Lulu0015 opened this issue Dec 12, 2024 · 3 comments

Comments

@Lulu0015
Copy link

Hi,

Thank you for developing this fantastic tool! I am trying to reproduce Figure 3e. I used the "parallel_inference.py" script from the /scripts/inference_motif_deletions folder to predict the motif effect after mutating all matching sites for GATA1 (motif #10 in the motif table). Using the code in /notebooks/figure3/Figure3.ipynb, I successfully reproduced the predictions for the reference sequences. However, my results for the mutated sequences differ from the example in the notebook. Do you have any suggestions for debugging this issue?

Thanks so much!
alt
ref

@lauradmartens
Copy link
Contributor

Hi!

Good catch, there was indeed a small mistake in the script that meant that the model never saw the alternative sequences. We fixed it now, let us know if it works for you!

Best,

Laura

@Lulu0015
Copy link
Author

Hi Laura,

Thanks so much! It was helpful. I can reproduce the motif effect for acc. now, but the motif effect for expr. still looks different. Any insight?

Thanks,
Lu
Screenshot 2024-12-17 at 11 07 12

@lauradmartens
Copy link
Contributor

Hi Lulu,

It should now be fixed, sorry for that. After our refactoring, we accidentally had incoherent settings for reference and motif deleted sequences. We also increased the cache_size argument which should lead to a significant speedup for the motif deletions.

Hope that helps!

Best,
Laura & Johannes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants