This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation of mock provider doesn't support any of the eth JSON RPC endpoints that establish subscriptions. Supporting this would allow for unit tests and smoke tests for implementations that depend on these features.
Solution
This implementation extends the idea of the mock provider being a sink of pre-rendered responses piped in before beginning the testing process. There is a simple public facing function
setup_subscription
that takes all the previously pushed responses and converts them into a stream that can be subscribed to using any of the eth JSONRPC requests that create such subscriptions.Internally, the implementation is a little convoluted because the
PubsubClient
takes an immutable reference toself
. The requirements of the task is that we need the mutable sender of a stream that we can push things to. The solution implemented here uses an intermediary stream that is initialized before thesubscribe
function is called, and it forwards all of its data to the stream that is returned by thesubscribe
function in thePubsubClient
trait.PR Checklist