Skip to content
This repository has been archived by the owner on Nov 11, 2024. It is now read-only.

Validate auth request payloads before sending requests to Dex #570

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

eamansour
Copy link
Contributor

@eamansour eamansour commented Jun 10, 2024

Why?

See galasa-dev/projectmanagement#1894

Changes

  • Added an initial TokenPayloadValidator class that implements a new IBeanValidator interface to handle the validation of auth request payloads
    • Eamonn: Not completely happy with this since this means every bean will end up with a corresponding validator class and constraints can't be re-used if another bean uses similar validation rules...
  • Added missing URL encoding to URL values in requests to Dex (since Dex expects request content to be application/x-www-form-urlencoded)

@galasa-team
Copy link

Build successful

Signed-off-by: Eamonn Mansour <[email protected]>
@galasa-team
Copy link

Build successful

@eamansour eamansour requested a review from techcobweb June 10, 2024 09:36
@galasa-team
Copy link

Build successful

@galasa-team
Copy link

Build successful

@galasa-team
Copy link

Build successful

@eamansour eamansour merged commit 9afeeee into main Jun 13, 2024
5 checks passed
@eamansour eamansour deleted the iss1894-validate-request-body branch June 13, 2024 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants