Skip to content
This repository has been archived by the owner on Nov 11, 2024. It is now read-only.

Set overrides in DSS as a single property, refactor code for submitting runs #654

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

eamansour
Copy link
Contributor

@eamansour eamansour commented Oct 4, 2024

Why?

See galasa-dev/projectmanagement#2000

Changes

  • Instead of setting multiple dss.framework.run.X.override.<override-property> properties into the DSS, the framework will now only set a single dss.framework.run.X.overrides property containing multiple overrides in a JSON array, for example:
dss.framework.run.C123.overrides=[{"key": "my.first.override", "value": "abc"}, {"key": "my.second.override", "value": "123"}]
  • Updated the consuming code in the test runner and framework initialisation to pull overrides out of this new property
  • Refactored the submitRuns method in the FrameworkRuns class and added unit tests

@eamansour eamansour requested a review from techcobweb October 7, 2024 09:34
Copy link
Contributor

@techcobweb techcobweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, if you can address my few comments pls.

@eamansour eamansour merged commit 70da23d into main Oct 7, 2024
6 checks passed
@eamansour eamansour deleted the iss2000-overrides-fix branch October 7, 2024 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants