Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set-version.sh should set version of boot jar also #308

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

techcobweb
Copy link
Contributor

@techcobweb techcobweb commented Nov 25, 2024

Signed-off-by: Mike Cobbett [email protected]

Why ?

Every release will bump the version of the maven and gradle files up we need to use.

Similarly, a different version of the galasa BOM needs to be referred to in test code.

  • Templatest changed
  • Galasa version threaded down into templates
  • Unit test added.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-308-qkb6v for details. If you are unable to do so, please contact a member of the Galasa team.

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-308-c7bn4 for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build successful

@techcobweb techcobweb merged commit 61775d2 into main Nov 27, 2024
6 checks passed
@techcobweb techcobweb deleted the mcobbett-all-versions-update-every-release branch November 27, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants