Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal Admin/Non-admin RBAC #2071 #324

Merged
merged 22 commits into from
Jan 2, 2025
Merged

Minimal Admin/Non-admin RBAC #2071 #324

merged 22 commits into from
Jan 2, 2025

Conversation

techcobweb
Copy link
Contributor

@techcobweb techcobweb commented Dec 30, 2024

Signed-off-by: Mike Cobbett [email protected]

Why ?

Part of the role based access foundation story: Minimal Admin/Non-admin RBAC
#2071

TODO:

  • Examples in the openapi.yaml need adding
  • Unit tests are incomplete. Coverage is down otherwise
  • List of role metadata expected, then gets role from list for detail. Needs re-work.
  • Blocks yaml format for list of roles. Needs re-work.
  • Readme instructions added
  • In the end I fixed up the generated beans.
  • fix-generated-code.sh added.
  • github actions build process changed to use that.
  • build-locally script changed to use that
  • tekton build process changed to use that
  • savvas hack removed + properties unit tests fixed.
  • secrets code changed to be simpler, no longer requires a deep copy operation.

@techcobweb techcobweb changed the title initial stab at some code. Incomplete Minimal Admin/Non-admin RBAC #2071 Dec 30, 2024
@galasa-team
Copy link

Build successful

@galasa-team
Copy link

Build successful

@techcobweb techcobweb marked this pull request as ready for review December 31, 2024 15:18
@galasa-team
Copy link

Build successful

Copy link
Member

@eamansour eamansour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments but approved

pkg/cmd/roles.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pkg/roles/roles.go Show resolved Hide resolved
pkg/rolesformatter/yamlFormatter_test.go Outdated Show resolved Hide resolved
@galasa-team
Copy link

Build successful

1 similar comment
@galasa-team
Copy link

Build successful

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-fthjb for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-lnngt for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-frgfz for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-qv6c5 for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-wsmp9 for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-974kz for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-cnzz7 for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-cwllp for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-cp47n for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-fqffq for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-k5h86-r-rnzjz for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-k5h86-r-8wjqq for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-k5h86-r-8zdgv for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-324-k5h86-r-bp29m for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build successful

@galasa-team
Copy link

Build successful

@galasa-team
Copy link

Build successful

@techcobweb techcobweb merged commit 8b96840 into main Jan 2, 2025
6 checks passed
@techcobweb techcobweb deleted the mcobbett-rbac branch January 2, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants