Iss1888 - Reference images in GHCR "docker proxy" instead of Harbor & fix broken adduser/addgroup for 'galasa' #337
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Carino <[email protected]>
Signed-off-by: Jade Carino <[email protected]>
|
Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-337-pcnzc for details. If you are unable to do so, please contact a member of the Galasa team. |
techcobweb
approved these changes
Feb 12, 2025
|
Build successful |
|
CodeQL check still not running for forks so merging with my admin rights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
For galasa-dev/projectmanagement#1888
Replacing references to images stored in Harbor with GHCR now they have been moved over to our "docker proxy cache". Harbor has been experiencing unexplained issues so pulling/pushing images there has been failing, and so PR builds have been failing sporadically all day. Moving our regularly used based images to GHCR removes the chance for these outages which affect our delivery.
&
As part of another story, to give the galasactl-x86_64 image access to bash, the FROM image of the image was updated from Alpine to Ubuntu. Since then this has broken the command to add a user and group of galasa as the syntax used in the Dockerfile is for Alpine Linux, not Ubuntu. In Ubuntu, adduser works differently, and useradd and groupadd should be used instead.
This fix has been tested by running the image within my fork (see workflow run here which is failing for another reason but is correctly being run with the galasa user, compared to a previous workflow run here where the user galasa wasn't found).