simple code changes to chip away at the code warnings #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Cobbett <[email protected]>
techcobweb
commented
Nov 14, 2024
modules/framework/galasa-parent/galasa-boot/src/main/java/dev/galasa/boot/Launcher.java
Show resolved
Hide resolved
techcobweb
commented
Nov 14, 2024
...alasa.framework.k8s.controller/src/main/java/dev/galasa/framework/k8s/controller/Health.java
Show resolved
Hide resolved
techcobweb
commented
Nov 14, 2024
...asa.cps.etcd/src/main/java/dev/galasa/cps/etcd/internal/Etcd3ConfigurationPropertyStore.java
Show resolved
Hide resolved
techcobweb
commented
Nov 14, 2024
modules/extensions/galasa-extensions-parent/dev.galasa.extensions.common/build.gradle
Show resolved
Hide resolved
techcobweb
commented
Nov 14, 2024
...api.users/src/main/java/dev/galasa/framework/api/users/internal/routes/UsersDeleteRoute.java
Show resolved
Hide resolved
eamansour
approved these changes
Nov 14, 2024
| @@ -262,7 +262,7 @@ public String get(@NotNull String key) throws DynamicStatusStoreException { | |||
| @Override | |||
| public @NotNull Map<String, String> getPrefix(@NotNull String keyPrefix) throws DynamicStatusStoreException { | |||
| ByteSequence bsPrefix = ByteSequence.from(keyPrefix, UTF_8); | |||
| GetOption options = GetOption.newBuilder().withPrefix(bsPrefix).build(); | |||
| GetOption options = GetOption.builder().withPrefix(bsPrefix).build(); | |||
There was a problem hiding this comment.
Need to change withPrefix here too?
| @@ -340,7 +340,7 @@ public void delete(@NotNull Set<String> keys) throws DynamicStatusStoreException | |||
| @Override | |||
| public void deletePrefix(@NotNull String keyPrefix) throws DynamicStatusStoreException { | |||
| ByteSequence bsKey = ByteSequence.from(keyPrefix, UTF_8); | |||
| DeleteOption options = DeleteOption.newBuilder().withPrefix(bsKey).build(); | |||
| DeleteOption options = DeleteOption.builder().withPrefix(bsKey).build(); | |||
There was a problem hiding this comment.
Need to change withPrefix here too?
| @@ -597,7 +597,7 @@ private Txn performActionsDeletePrefixIf(Txn txn, DssDeletePrefix action) { | |||
| private Txn performActionsDeletePrefixThen(Txn txn, DssDeletePrefix action) { | |||
| ByteSequence bsKey = ByteSequence.from(action.getPrefix(), UTF_8); | |||
|
|
|||
| DeleteOption option = DeleteOption.newBuilder().withPrefix(bsKey).build(); | |||
| DeleteOption option = DeleteOption.builder().withPrefix(bsKey).build(); | |||
There was a problem hiding this comment.
Need to change withPrefix here too?
| @@ -1,6 +1,13 @@ | |||
| # Galasa | |||
| This is a home for all of the Galasa code | |||
| This is a home for all of the code Java Galasa code. | |||
There was a problem hiding this comment.
"code" is here twice - maybe something like "all of the Galasa Java code"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mike Cobbett [email protected]