Added detect-secrets to workflow #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aashir Siddiqui <[email protected]>
Signed-off-by: Aashir Siddiqui <[email protected]>
jadecarino
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Hi Ash, so GitHub Actions workflows are structured in a hierarchy of workflow > jobs > steps. In this workflow there are the jobs get-changed-modules, find-artifacts, and then several pr-build-* which are jobs that call other workflows (known as reusable workflows). The two steps you have added have been put into the find-artifacts job which would work, but they should be put in their own job so that 1 each job does a specific thing and 2 jobs can run in parallel to eachother (steps cannot) so the detect-secrets can run while other things are happening.
Please move the steps into their own job as described in the comment.
Signed-off-by: Aashir Siddiqui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Signed-off-by: Aashir Siddiqui [email protected]