Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dev.galasa.platform from the release.yaml #80

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

jadecarino
Copy link
Contributor

@jadecarino jadecarino commented Nov 27, 2024

Why?

dev.galasa.platform still needs to be part of the Isolated/MVP zips but being in the release.yaml should only be for artifacts that are built and put into the zip as a jar. dev.galasa.platform being here in the release.yaml (which is used to generate a pom.xml for the Isolated/MVP zips) has caused this error:

Could not find artifact dev.galasa:dev.galasa.platform:jar:0.38.0 in galasa.runtime.repo (https://development.galasa.dev/main/maven-repo/obr)

dev.galasa.platform can be included in Isolated/MVP instead as a POM artifact correctly by adding this section into the Isolated and MVP's pom.templates:

        <dependency>
            <groupId>dev.galasa</groupId>
            <artifactId>dev.galasa.platform</artifactId>
            <version>{{.Release}}</version>
            <type>pom</type>
        </dependency>

@jadecarino jadecarino merged commit 0038f0a into main Nov 27, 2024
28 checks passed
@jadecarino jadecarino deleted the jade-remove-platform-from-release.yaml branch November 27, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants