Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing using Ansible Molecule #10

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

kysrpex
Copy link
Contributor

@kysrpex kysrpex commented Dec 11, 2023

Test the role on the supported platforms specified in commit f1dc9d3.

Test the role on the supported platforms specified in commit f1dc9d3.
@kysrpex
Copy link
Contributor Author

kysrpex commented Dec 11, 2023

Please if you approve this and #11, merge without the tests passing (they pass after merging #11). Alternatively merge #11 first and then merge main into this one. Or just do whatever you think makes sense.

Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic improvement, thank you so much for contributing tests! It will be so good to have these in more repos :)

The only failures are due to missing git, I think we should maybe just get rid of that completely and download directly the final binary

.github/workflows/molecule-requirements.txt Show resolved Hide resolved
@hexylena
Copy link
Member

I have looked into replacing git with community.general.github_release but it introduces a new dependency on a python module which is worse. So we stick with the git dependency for now.

We could alternatively hardcode the version of gxadmin to download, I'm not certain what's best there. gxadmin is certainly a lot more stable now (in favour of automatic updates), but maybe admins want to control such minute details (they already can by setting the git revision.)

@hexylena hexylena merged commit f97de64 into galaxyproject:main Dec 11, 2023
1 of 2 checks passed
@kysrpex
Copy link
Contributor Author

kysrpex commented Dec 11, 2023

I have looked into replacing git with community.general.github_release but it introduces a new dependency on a python module which is worse. So we stick with the git dependency for now.

Well, considering the conversation from #11, I think the a reasonable solution is to add the stuff that #11 does to install the role dependencies to the prepare.yml playbook for now. After all, that is what it is supposed to do.

  • prepare: prepare the instance: install any needed packages for the tested role/playbook

@kysrpex
Copy link
Contributor Author

kysrpex commented Dec 11, 2023

Noo, I wanted to fix that last detail before you merged 😢, I will make another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants