Make CVMFS fix configurable #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add in VALUES.md and README.md fix: add mising \n in configmap
nuwang
reviewed
Aug 12, 2024
There was a problem hiding this comment.
Thanks for this fix @NilsKrattinger. My only suggestion is that we add the deployPostInstallFix flag only, and remove the externalCvmfsNamespace option. This fix was never meant to be permanent, just a temporary workaround till the upstream csi chart is fixed. I think it's preferable to simply document the steps or manually restart the csi pods instead.
|
@NilsKrattinger Thanks for the changes. @ksuderman is also investigating whether this may have been fixed upstream, and hopefully he has some good news to share. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a option to not deploy the CVMFS-fix.
Add ability to restart nodeplugin even if deployed on other namespaceAdd condition to not create the cvmfs-fix configmap if CVMFS isn't used / deployed as CSI for refdata.
Close #494.
Impact #441.