Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency charts; save outputs to working dir #501

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update dependency charts; save outputs to working dir #501

wants to merge 6 commits into from

Conversation

afgane
Copy link
Contributor

@afgane afgane commented Sep 11, 2024

I tested the updated deps on a K32 (1.30) cluster and worked as expected.

The outputs_to_working_directory option was a conclusion from a recent discussion.

@afgane afgane added the minor label Sep 11, 2024
ksuderman
ksuderman requested changes Sep 11, 2024
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
@afgane
Copy link
Contributor Author

afgane commented Sep 11, 2024

I don't understand what's going on with the tests so I hope it is transient. What worked a few hours ago on a VM now doesn't so I'll just wait a bit for now.

Downloading postgres-operator from repo https://opensource.zalando.com/postgres-operator/charts/postgres-operator/
Save error occurred:  could not download postgres-operator-1.9.0.tgz: non-absolute URLs should be in form of repo_name/path_to_chart, got: postgres-operator-1.9.0.tgz
Error: could not download postgres-operator-1.9.0.tgz: non-absolute URLs should be in form of repo_name/path_to_chart, got: postgres-operator-1.9.0.tgz

nuwang
nuwang reviewed Sep 12, 2024
View reviewed changes
galaxy/Chart.yaml Outdated
condition: cvmfs.deploy
alias: cvmfs
tags:
- deploy-cvmfs
- name: rabbitmq-cluster-operator
repository: https://charts.bitnami.com/bitnami
version: 2.6.12
version: 4.3.22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there have been two major version changes. Have these changed the yaml configs in anyway?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. These are the only notes I was able to find re. the release/upgrade process and nothing there seems to conflict with our setup: https://github.com/bitnami/charts/tree/main/bitnami/rabbitmq-cluster-operator#to-400

I launched 3 clusters with this version and ran a few IWC workflows, all of which worked as expected.

nuwang
nuwang approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@nuwang nuwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Would outputs_to_working_directory solve the permission issue that was encountered?

@ksuderman
Copy link
Contributor

Looks great! Would outputs_to_working_directory solve the permission issue that was encountered?

Good questions! I'll test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksuderman ksuderman ksuderman requested changes

@nuwang nuwang nuwang approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afgane @ksuderman @nuwang