Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust static file staging location handling #2741

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Adjust static file staging location handling #2741

merged 5 commits into from
Aug 20, 2024

Conversation

dannon
Copy link
Member

@dannon dannon commented Aug 19, 2024 •
edited
Loading

Uses lodash.kebabcase to handle paths like:

news-2024-08-14-GalaxyInResearch/GalaxyInResearch_Jain2024.png
Which should be:
news-2024-08-14-galaxy-in-research/GalaxyInResearch_Jain2024.png
And not the simple lower(), like:
news-2024-08-14-galaxyinresearch/GalaxyInResearch_Jain2024.png

@dannon dannon changed the title Kebab links Adjust static file staging location handling Aug 19, 2024
@dannon dannon marked this pull request as ready for review August 19, 2024 19:41
@dannon
Copy link
Member Author

dannon commented Aug 19, 2024

Frustratingly, this still doesn't match the standard. We kebab-case CapitalizedNames, but not between numbers as in gcc2024. Another iteration.

@dannon dannon marked this pull request as draft August 19, 2024 20:12
@dannon dannon marked this pull request as ready for review August 20, 2024 01:48
@dannon dannon merged commit a35904b into galaxyproject:master Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dannon