Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md of BFSP-FairyMAGs news #2890

Conversation

dadrasarmin
Copy link
Contributor

The images were not loaded. I think now it should be visible.

The images were not loaded. I think now it should be visible.
@bgruening
Copy link
Member

figcaption is used a few times in the code: https://github.com/search?q=repo%3Agalaxyproject%2Fgalaxy-hub%20figcaption&type=code

Could you check if this also does not work in the other posts?

@dadrasarmin
Copy link
Contributor Author

dadrasarmin commented Jan 15, 2025

I am not proficient in HTML tags and syntax, but the pattern I see is as follows:
This does NOT work:

<figure>
<img src="file.png" alt="second_name"/> 
<figcaption>Some text</figcaption> 
</figure>

But this works:

![second_name](file.png)

</div>  
<figcaption>
  Some text
</figcaption>
</div>  

this 3rd format also works:

<figure class="figure">
  <g-image src="./file.png" class="figure-img img-fluid rounded" />
  <figcaption class="figure-caption">Some text.</figcaption>
</figure>

All the links that were in the figcaption, besides this one, would show the image.

@bgruening
Copy link
Member

ok, lets use:

<figure class="figure">
  <g-image src="./file.png" class="figure-img img-fluid rounded" />
  <figcaption class="figure-caption">Some text.</figcaption>
</figure>

Thanks for figuring this out.

@bgruening bgruening merged commit 05fb163 into galaxyproject:master Jan 15, 2025
2 checks passed
@dadrasarmin dadrasarmin deleted the dadrasarmin-BFSP-FairyMAGs-image-loading branch January 21, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants