Move update to tag handler

galaxyproject · Apr 30, 2024 · 407708f · 407708f
1 parent a1fc936
commit 407708f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/lib/galaxy/model/tags.py b/lib/galaxy/model/tags.py
@@ -95,6 +95,7 @@ def set_tags_from_list(
         if flush:
             with transaction(self.sa_session):
                 self.sa_session.commit()
+        item.update()
         return item.tags
 
     def get_tag_assoc_class(self, item_class):

diff --git a/lib/galaxy/webapps/galaxy/services/history_contents.py b/lib/galaxy/webapps/galaxy/services/history_contents.py
@@ -1513,10 +1513,6 @@ def _change_dbkey(self, item: HistoryItemModel, params: ChangeDbkeyOperationPara
 
     def _add_tags(self, trans: ProvidesUserContext, item: HistoryItemModel, params: TagOperationParams):
         trans.tag_handler.add_tags_from_list(trans.user, item, params.tags, flush=self.flush)
-        # Changing tags does not change the item, but we need to update the history to trigger the completion of the operation
-        item.update()
 
     def _remove_tags(self, trans: ProvidesUserContext, item: HistoryItemModel, params: TagOperationParams):
         trans.tag_handler.remove_tags_from_list(trans.user, item, params.tags, flush=self.flush)
-        # Changing tags does not change the item, but we need to update the history to trigger the completion of the operation
-        item.update()