Skip to content

Commit

Permalink
fix selenium by only hiding label in NodeInput with props.blank
Browse files Browse the repository at this point in the history
Otherwise, seleniums would fail for:
```
Timeout waiting on CSS selector [[node-label='...'] [input-name='...'] + .delete-terminal-button] to become clickable.
```
  • Loading branch information
ahmedhamidawan committed Apr 18, 2024
1 parent 7edbc49 commit a601310
Showing 1 changed file with 15 additions and 17 deletions.
32 changes: 15 additions & 17 deletions client/src/components/Workflow/Editor/NodeInput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -238,23 +238,21 @@ watch(
</b-tooltip>
<FontAwesomeIcon class="terminal-icon" icon="fa-chevron-circle-right" />
</div>
<span v-if="!blank">
<button
v-if="hasConnections && !readonly"
v-b-tooltip.hover
:title="reason"
class="delete-terminal-button"
@click="onRemove">
<FontAwesomeIcon class="delete-button-icon" icon="fa-minus-square" />
</button>
{{ label }}
<span
v-if="!input.optional && !hasTerminals"
v-b-tooltip.hover
class="input-required"
title="Input is required">
*
</span>
<button
v-if="hasConnections && !readonly"
v-b-tooltip.hover
:title="reason"
class="delete-terminal-button"
@click="onRemove">
<FontAwesomeIcon class="delete-button-icon" icon="fa-minus-square" />
</button>
<span v-if="!blank">{{ label }}</span>
<span
v-if="!input.optional && !hasTerminals"
v-b-tooltip.hover
class="input-required"
title="Input is required">
*
</span>
</div>
</template>
Expand Down

0 comments on commit a601310

Please sign in to comment.