Fix bug by using model association instead of string comparison

galaxyproject · Oct 4, 2024 · d551f9b · d551f9b
1 parent 1f5a9f1
commit d551f9b
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/lib/galaxy/model/security.py b/lib/galaxy/model/security.py
@@ -792,10 +792,13 @@ def create_role(self, name, description, in_users, in_groups, create_group_for_r
         return role, num_in_groups
 
     def get_sharing_roles(self, user):
-        stmt = select(Role).where(
-            and_((Role.name).like(f"Sharing role for: %{user.email}%"), Role.type == Role.types.SHARING)
+        stmt = (
+            select(Role)
+            .join(Role.users)
+            .where(UserRoleAssociation.user_id == user.id)
+            .where(Role.type == Role.types.SHARING)
         )
-        return self.sa_session.scalars(stmt)
+        return self.sa_session.scalars(stmt).all()
 
     def user_set_default_permissions(
         self,