Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool linter: simple test for test params absent from inputs #12723

Merged
merged 4 commits into from
Nov 16, 2021

Conversation

bernt-matthias
Copy link
Contributor

The IUC tools directory contains approx. 54 such cases.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these contributions under Galaxy's current license.
  • I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Are the IUC hits all legitimate ?

lib/galaxy/tool_util/linters/tests.py Outdated Show resolved Hide resolved
test/unit/tool_util/test_tool_linters.py Outdated Show resolved Hide resolved
@bernt-matthias
Copy link
Contributor Author

This is awesome! Are the IUC hits all legitimate ?

See galaxyproject/tools-iuc#4095 I checked a couple of them and all of them were.

I also thought about matching test params and input params. But this seemed to complicated .. but ideas are welcome.

test/unit/tool_util/test_tool_linters.py Outdated Show resolved Hide resolved
test/unit/tool_util/test_tool_linters.py Outdated Show resolved Hide resolved
@nsoranzo nsoranzo merged commit 0b5ba63 into galaxyproject:dev Nov 16, 2021
@bernt-matthias bernt-matthias deleted the topic/lint-missing-inputs branch March 14, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants