Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Activity Bar Settings to Activity #17457

Conversation

ElectronicBlueberry
Copy link
Member

image

Moves the settings from a context menu to the settings activity.

Additional changes:

  • make activity toggles buttons
  • adjust style of activity panel wrapper to be more in line with previous activities
  • re-use one flex panel for all activities, so it's size does not reset when switching
  • add optional href to full view button, so it can opened in a new tab

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ElectronicBlueberry
Copy link
Member Author

xref #17284

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good!

@@ -43,7 +45,7 @@ const emit = defineEmits(["goToAll"]);
height: 100%;
display: flex;
flex-flow: column;
padding: 0.5rem 0.25rem;
padding: 0.5rem 1rem;
Copy link
Member

@itisAliRH itisAliRH Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ii´s looks like there's too much padding; I would prefer 0.5rem here:
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the same spacing as the tool box. I'm open to change it, but if we do we should do so for the tool box as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to use the activity panel for the tool box as well to have a consistent UI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a different and controversial option ... can we merge without that ?

Copy link
Member Author

@ElectronicBlueberry ElectronicBlueberry Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer keeping it aligned with existing styles for now, and making any style changes in a separate PR.
That way we can discuss there in more detail

Copy link
Member

@itisAliRH itisAliRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Only a few small fixes. The scroll bar is always visible:
image

@ElectronicBlueberry
Copy link
Member Author

Looks good to me, thanks!

Only a few small fixes. The scroll bar is always visible: image

Good catch, thanks!

@ElectronicBlueberry ElectronicBlueberry merged commit 289ec3c into galaxyproject:dev Feb 14, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants