-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place invocation state in list #17708
Draft
jmchilton
wants to merge
14
commits into
galaxyproject:dev
Choose a base branch
from
jmchilton:place_state_in_invocation_list
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Place invocation state in list #17708
jmchilton
wants to merge
14
commits into
galaxyproject:dev
from
jmchilton:place_state_in_invocation_list
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have also added modifications to the Summary tab here: #17413, which will work nicely with these changes! |
jmchilton
force-pushed
the
place_state_in_invocation_list
branch
from
March 25, 2024 17:55
00de142
to
ec403cc
Compare
jmchilton
force-pushed
the
place_state_in_invocation_list
branch
from
April 3, 2024 17:12
b47999a
to
31d9b48
Compare
Errors seem related - might close this out and get smaller pieces merged first to narrow things down. |
jmchilton
force-pushed
the
place_state_in_invocation_list
branch
from
April 17, 2024 15:51
31d9b48
to
1f0731e
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual invocation state we decided wasn't very useful at the team meeting. Foregrounding the progress bars is a potential improvement. I've done some query optimization for this.
Screen.Recording.2024-03-13.at.5.20.19.PM.mov
How to test the changes?
(Select all options that apply)
License