Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stronger type annotations in file sources + refactoring #18050

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Add stronger type annotations in file sources + refactoring #18050

merged 1 commit into from
Apr 29, 2024

Conversation

davelopez
Copy link
Contributor

Maybe it is a bit too much, but with this, all functions are consistently annotated around file sources.

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez added kind/refactoring cleanup or refactoring of existing code, no functional changes area/backend labels Apr 24, 2024
@davelopez davelopez closed this Apr 24, 2024
@davelopez davelopez reopened this Apr 24, 2024
@davelopez davelopez mentioned this pull request Apr 24, 2024
Merged
2 tasks
@davelopez davelopez force-pushed the file_sources_typings branch 3 times, most recently from 3273615 to 6489230 Compare April 24, 2024 15:40
@davelopez davelopez marked this pull request as ready for review April 25, 2024 11:07
@github-actions github-actions bot added this to the 24.1 milestone Apr 25, 2024
@jmchilton
Copy link
Member

This seems great! Thank you so much!

@davelopez
Copy link
Contributor Author

This one is ready to go unless there is anything to improve :)

@bgruening bgruening merged commit 4e2aaf8 into galaxyproject:dev Apr 29, 2024
53 checks passed
@davelopez davelopez deleted the file_sources_typings branch April 29, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
area/backend kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.
3 participants
@davelopez @jmchilton @bgruening