Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable flake8-implicit-str-concat ruff rules #18067

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Enable flake8-implicit-str-concat ruff rules #18067

merged 1 commit into from
Apr 29, 2024

Conversation

nsoranzo
Copy link
Member

See https://docs.astral.sh/ruff/rules/#flake8-implicit-str-concat-isc

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo nsoranzo added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Apr 29, 2024
@github-actions github-actions bot added this to the 24.1 milestone Apr 29, 2024
jdavcs
jdavcs approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nsoranzo!

@jdavcs jdavcs merged commit 9ef2c39 into galaxyproject:dev Apr 29, 2024
55 checks passed
@nsoranzo nsoranzo deleted the flake8-implicit-str-concat branch April 29, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdavcs jdavcs jdavcs approved these changes

Assignees
No one assigned
Labels
area/API area/auth Authentication and authorization area/database Galaxy's database or data access layer area/datatypes area/jobs area/objectstore area/scripts area/testing area/tool-framework area/tools area/util kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nsoranzo @jdavcs