Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to Heading component; correct imports and default props. #18073

Closed
wants to merge 1 commit into from
Closed

Minor fixes to Heading component; correct imports and default props. #18073

wants to merge 1 commit into from

Conversation

dannon
Copy link
Member

@dannon dannon commented Apr 30, 2024

Adjusts default prop configuration and usage, fixes imports from #16983's last minute tweaks.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon added the minor label Apr 30, 2024
@dannon dannon marked this pull request as ready for review April 30, 2024 13:09
@github-actions github-actions bot added this to the 24.1 milestone Apr 30, 2024
@dannon
Copy link
Member Author

dannon commented Apr 30, 2024

Nevermind, I just pushed this to #17413 along with resolving the conflict there.

@dannon dannon closed this Apr 30, 2024
@itisAliRH itisAliRH deleted the minor-heading-fixes branch June 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/UI-UX minor
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.
1 participant
@dannon