Record container id and type in core job metrics

[mvdbeek]

Closes #16588. Not sure if we want to do this versus a separate but always loaded plugin vs a regular relationship in the database.

Seems unlikely that we'd do anything beyond reporting, so maybe this is fine for now ?

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[jmchilton]

This has been... honestly very high... on my priority list for like 9 years at this point I think 😅.

[mvdbeek]

This has changed a little, still ok @jmchilton ?

[jmchilton]

FAILED test/integration/test_kubernetes_runner.py::TestKubernetesIntegration::test_explicit - AttributeError: 'TestKubernetesIntegration' object has no attribute 'container_type'

is this related?

[mvdbeek]

Yep, thanks!

[github-actions]

This PR was merged without a "kind/" label, please correct.

[nsoranzo]

Sorry for the late review, I think you need to add the container_type class attribute also to https://github.com/galaxyproject/galaxy/blob/dev/test/integration/test_coexecution.py#L242 ? Tests pass because this is skipped in GitHub workflows.