Parameter Model Improvements #18641
Merged
Parameter Model Improvements #18641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
model_parameter_improvements_1
branch
7 times, most recently
from
7d5e7e0
to
592f2c3
Compare
…dule. Add explicit exports to package galaxy.tool_util.verify.
jmchilton
force-pushed
the
model_parameter_improvements_1
branch
3 times, most recently
from
243c258
to
e4d0457
Compare
jmchilton
force-pushed
the
model_parameter_improvements_1
branch
from
e4d0457
to
a8a8199
Compare
mvdbeek
approved these changes
Aug 6, 2024
Comment on lines
+27
to
+29
| <!-- Selects have an implicit first option default in tool tests. | ||
| Do they in the actual API also? | ||
| --> |
There was a problem hiding this comment.
Suggested change
| <!-- Selects have an implicit first option default in tool tests. | |
| Do they in the actual API also? | |
| --> | |
| <!-- Selects implicitly default to the first option as the default option. | |
| Additional verification in test_select_first_by_default API test. | |
| --> |
I wonder if this is good behavior overall ? Say we're missing any valid options, when would we catch this during validation ?
There was a problem hiding this comment.
It is all green enough - I'll fix this comment as the first thing I do in my next model rev - I am sure a new PR will be open this week. Thanks
|
|
||
| @property | ||
| def request_requires_value(self) -> bool: | ||
| return False |
There was a problem hiding this comment.
I'm at least a little surprised 😅
There was a problem hiding this comment.
Just a first cut - I think it has slightly different behavior based on how it is configured. The tests will keep coming.
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits - all enhancements stemming from downstream work on validating workflows and tool test cases with the models introduced in #18524 as part of the broader structured tool state work #17393 / https://docs.google.com/document/d/1HQOLpLN54CjrB-wbD463XqzvUm-dNB8vTXUFBExh_2o/edit.
How to test the changes?
(Select all options that apply)
License