Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade bundled/requested node version to 20.16.0 #18710

Draft
wants to merge 13 commits into
base: dev
Choose a base branch
from
Draft

Upgrade bundled/requested node version to 20.16.0 #18710

wants to merge 13 commits into from

Commits on Sep 23, 2024

  1. Test w/ node version 20 in advance of updating default Galaxy pinned … 

    …nodejs
    @dannon
    dannon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8ac6cdc View commit details
    Browse the repository at this point in the history

  2. Upgrade galaxy default installed/pinned nodejs version to v20, from v18. 

    See node release chart: https://nodejs.org/en/about/previous-releases

Node 20 is the current "Active LTS" and will be so until node 22 enters
active LTS later this fall.
    @dannon
    dannon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    96cb4bd View commit details
    Browse the repository at this point in the history

  3. Bump jest/lint node versions, use specific pinned ver

    @dannon
    dannon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a99326a View commit details
    Browse the repository at this point in the history

  4. Test using a composite action to wrap all the node config

    @dannon
    dannon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    7479899 View commit details
    Browse the repository at this point in the history

  5. Don't require node version -- use default to consolidate

    @dannon
    dannon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8d99bef View commit details
    Browse the repository at this point in the history

  6. yml->yaml

    @dannon
    dannon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b456b60 View commit details
    Browse the repository at this point in the history

  7. Composite actions shouldn't be in workflows?

    @dannon
    dannon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3c76334 View commit details
    Browse the repository at this point in the history

  8. Shift setup-node to action.yaml

    @dannon
    dannon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d9160e4 View commit details
    Browse the repository at this point in the history

  9. Is this what it wants for composite actions? rebase me

    @dannon
    dannon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d1b5038 View commit details
    Browse the repository at this point in the history

  10. Use galaxy root cache path

    @dannon
    dannon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ea3b0c1 View commit details
    Browse the repository at this point in the history

  11. Swap actions to use setup-node composite action.

    @dannon
    dannon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b6bfa0d View commit details
    Browse the repository at this point in the history

  12. Fix default cache path

    @dannon
    dannon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ddd66bb View commit details
    Browse the repository at this point in the history

  13. Is this it? (rebase)

    @dannon
    dannon committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b90d8e8 View commit details
    Browse the repository at this point in the history