[24.1] Fix subworkflow scheduling for delayed subworkflow steps connected to data inputs #18731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the scheduling portion of galaxyproject#18697 This would be a problem for all workflows that require delayed scheduling and whose inputs are not outputs of tool steps.
This would currently just fail with an exception in the logs. I ran into this while manually defining a gxformat2 workflow and not referencing the right step.
mvdbeek
changed the title
|
Test failures should all be unrelated. |
jmchilton
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case it's the when statement that causes the step to be delayed. Because we didn't run through the WorkflowModule recover_mapping function we were missing the input steps output after the first round of scheduling (i.e the first time we should have recovered the input data step outputs).
Also adds an explicit scheduling failure if a subworkflow step didn't produce an expected output.
How to test the changes?
(Select all options that apply)
License