[24.1] Fix infinite rapid polling in useKeyedCache #18756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
fix_infinite_polling_useKeyedCache
branch
2 times, most recently
from
ca81c91
to
d2bedc8
Compare
jmchilton
approved these changes
Sep 1, 2024
|
Those testing errors do look real ... |
We were previously not showing error message at all if the user didn't have permissions to edit a collection (or fetching a collection has failed for another reason).
mvdbeek
force-pushed
the
fix_infinite_polling_useKeyedCache
branch
from
d2bedc8
to
59607f1
Compare
mvdbeek
changed the title
mvdbeek
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://sentry.galaxyproject.org/share/issue/e68b539766464e76a627c80333430c82/, which caused 250K events in less than 2 days.
To reproduce try editing a collection you don't own via
<galaxy_url>/collection/<hdca_id>/edit.How to test the changes?
(Select all options that apply)
License