Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix wrong extension on pick data output #18798

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 10, 2024

And set failed metadata state if we're trying something that can't work.
Also maintains the dataset inheritance chain.
Fixes #18795

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test failures look legit and the schema needs to be regenerated.

@mvdbeek mvdbeek force-pushed the fix_wrong_extension_on_pick_data_output branch from eb0d54f to ee63214 Compare September 11, 2024 10:21
@mvdbeek mvdbeek merged commit a6d8851 into galaxyproject:release_24.1 Sep 11, 2024
49 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants