Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Use smtplib send_message to support utf-8 chars in to and from #18805

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 12, 2024

Fixes #18804.
Manually tested with docker run --rm -it -p 5001:80 -p 2525:25 rnwood/smtp4dev which pretty convenient.
Screenshot 2024-09-12 at 15 23 31

Screenshot 2024-09-12 at 15 23 36

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek changed the base branch from dev to release_24.1 September 12, 2024 13:26
@github-actions github-actions bot added this to the 24.2 milestone Sep 12, 2024
@mvdbeek mvdbeek changed the title Use smtplib send_message to support utf-8 chars in to and from [24.1] Use smtplib send_message to support utf-8 chars in to and from Sep 12, 2024
@github-actions github-actions bot modified the milestones: 24.2, 24.1 Sep 12, 2024
Also:
- Remove unnecessary `unicodify()` calls
@nsoranzo
Copy link
Member

@mvdbeek I've pushed a small refactoring to ensure the SMTP connection is terminated also if send_message() raises an exception, if you'd like to test it.

@mvdbeek mvdbeek merged commit 0ebb604 into galaxyproject:release_24.1 Sep 13, 2024
47 of 49 checks passed
@nsoranzo nsoranzo deleted the send_message_utf8 branch September 13, 2024 10:15
@galaxyproject-sentryintegration

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SMTPNotSupportedError: One or more source or delivery addresses require internationalized email support, but the server ... https://127.0.0.1:8081/user/create View Issue

Did you find this useful? React with a 👍 or 👎

@nsoranzo
Copy link
Member

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

* ‼️ **SMTPNotSupportedError: One or more source or delivery addresses require internationalized email support, but the server ...** `https://127.0.0.1:8081/user/create` [View Issue](https://sentry.galaxyproject.org/organizations/galaxy/issues/161078/?referrer=github-pr-bot)

It seems the usegalaxy.org's email server doesn't support the SMTPUTF8 capability @natefoo ?

@mvdbeek
Copy link
Member Author

mvdbeek commented Sep 19, 2024

Ad while we're at it, I think vgp.usegalaxy.org doesn't support sending emails at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email sending fails for addresses with non-ascii characters
2 participants