Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Make pylibmagic import optional #18813

Merged

Commits on Sep 14, 2024

  1. Make pylibmagic import optional

    I was trying to use the galaxy-data container for data source tools,
    but it fails with:
    ```
    Traceback (most recent call last):
      File "/Users/mvandenb/src/galaxy/test/functional/tools/data_source.py", line 13, in <module>
        from galaxy.datatypes import sniff
      File "/usr/local/lib/python3.12/site-packages/galaxy/datatypes/sniff.py", line 40, in <module>
        import pylibmagic  # noqa: F401  # isort:skip
        ^^^^^^^^^^^^^^^^^
    ModuleNotFoundError: No module named 'pylibmagic'
    ```
    pylibmagic is just shipping the magic library and adds it to path,
    but that's not needed for the data-data container which can use magic
    just fine.
    mvdbeek committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    b6d0d51 View commit details
    Browse the repository at this point in the history