[24.0] Ignore converted datasets in invalid input states #18850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug reported by @jennaj where using an input dataset from a history import (which contains implicitly converted datasets in discarded state) in an input that would require that exact same implicit conversion would fail with `Job output deleted by user before job completed`. This will make the whole implicit coversion system much more robust, since we didn't even exclude datasets in error state, so as soon as one conversion failed ... you'd be stuck.
mvdbeek
force-pushed
the
fix_implicit_input_selection
branch
from
0c746fb
to
1cf024b
Compare
|
Test failures are all unrelated |
davelopez
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug reported by @jennaj where using an input dataset from a history import (which contains implicitly converted datasets in discarded state) in an input that would require that exact same implicit conversion would fail with
Job output deleted by user before job completed.This will make the whole implicit coversion system much more robust, since we didn't even exclude datasets in error state, so as soon as one conversion failed ... you'd be stuck.
How to test the changes?
(Select all options that apply)
License