Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test/integration_selenium/test_toolbox_filters.py::TestToolboxFiltersSeleniumIntegration::test_toolbox_filters #18854

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix flaky test/integration_selenium/test_toolbox_filters.py::TestToolboxFiltersSeleniumIntegration::test_toolbox_filters #18854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c4b3bc
Fix flaky `test/integration_selenium/test_toolbox_filters.py::TestToo…
ahmedhamidawan Sep 19, 2024
408366d
remove redundant sleep for
ahmedhamidawan Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/src/utils/navigation/navigation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ edit_collection_attributes:

tool_panel:
selectors:
tool_box: '[data-description="panel toolbox"]'
tool_link: 'a[href$$="tool_runner?tool_id=${tool_id}"]'
outer_tool_link: '.toolTitle a[href$$="tool_runner?tool_id=${tool_id}"]'
data_source_tool_link: 'a[href$$="tool_runner/data_source_redirect?tool_id=${tool_id}"]'
Expand Down
2 changes: 2 additions & 0 deletions test/integration_selenium/test_toolbox_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def test_toolbox_filters(self):
the specified section is no longer displayed in the browser.
"""
self.register()
self.components.tool_panel.tool_box.wait_for_visible()
# The tool panel section should be visible and clickable at this stage
section = self.driver.find_element(By.LINK_TEXT, "Test Section")
self.action_chains().move_to_element(section).click().perform()
Expand All @@ -41,6 +42,7 @@ def test_toolbox_filters(self):
self.components.toolbox_filters.submit.wait_for_and_click()
self.sleep_for(self.wait_types.UX_RENDER)
self.home()
self.components.tool_panel.tool_box.wait_for_visible()
# But now it should raise NoSuchElementException
with self.assertRaises(NoSuchElementException):
self.driver.find_element(By.LINK_TEXT, "Test Section")
Loading