Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Limit max number of items in dataproviders #18881

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 24, 2024

that support pagination to 10000. Clients can always request more data via offset requests, but since this is not a streaming API we need to build the response in memory before we can start sending.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone Sep 24, 2024
@mvdbeek mvdbeek force-pushed the dont_read_contents_into_memory branch from c0e3ed9 to 78d6d6e Compare September 25, 2024 10:45
that support pagination to 10000. Clients can always request more data via offset
requests, but since this is not a streaming API we need to build the
response in memory before we can start sending.
@mvdbeek mvdbeek force-pushed the dont_read_contents_into_memory branch from 78d6d6e to 2f1b6e2 Compare September 25, 2024 10:46
@martenson martenson merged commit b3f3165 into galaxyproject:release_24.1 Sep 25, 2024
48 of 51 checks passed
@galaxyproject-sentryintegration
Copy link

galaxyproject-sentryintegration bot commented Sep 25, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ReferenceDataError: No reference data for Arabidopsis_thaliana_TAIR10 /api/datasets/{dataset_id} View Issue
  • ‼️ NoProviderAvailable: No provider available in factory_source "<galaxy.datatypes.registry.Text object at 0x7f26d7653610... /api/datasets/{dataset_id} View Issue
  • ‼️ AttributeError: 'NoneType' object has no attribute 'upper' /api/datasets/{dataset_id} View Issue
  • ‼️ ValueError: invalid literal for int() with base 10: '2.44214' /api/datasets/{dataset_id} View Issue
  • ‼️ AttributeError: 'NoneType' object has no attribute 'get_filters' /api/datasets/{dataset_id} View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants