Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a few global defaults for file source plugin types. #18909

Merged

Conversation

jmchilton
Copy link
Member

The idea is we don't want users having to define the technical details of plugin specification that are related to the infrastructure of Galaxy and not the remote data source. Even allowing them in the templates is kind of heavy - so being able to just set them in Galaxy's config is sort of ideal.

Even outside the context of user defined file sources - I think this is kind of an important point. Take for example - https://github.com/galaxyproject/usegalaxy-playbook/blob/main/env/common/templates/galaxy/config/file_sources_conf.yml.j2 - it is very heavy and error prone that the "listings_expiry_time" parameter needs to be defined in each plugin.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton force-pushed the file_source_property_global_defaults branch 13 times, most recently from 5849b06 to 1899eb1 Compare October 1, 2024 22:58
@jmchilton jmchilton marked this pull request as ready for review October 2, 2024 13:01
@jmchilton
Copy link
Member Author

I also fixed up and expanded some webdav tests. Directions are at the top of the test_webdav.py if you want to run them.

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much John!
I wouldn't expect we would add more configuration values to the config schema... I thought we were trying to avoid adding more, but I'm not an admin, so I'm not complaining 😝

You may need to run make config-rebuild

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the nitpicking here ... I guess I would only insist on flipping the use_temp_files setting to true.

lib/galaxy/files/plugins.py Show resolved Hide resolved
lib/galaxy/config/schemas/config_schema.yml Outdated Show resolved Hide resolved
lib/galaxy/config/schemas/config_schema.yml Outdated Show resolved Hide resolved
@jmchilton jmchilton marked this pull request as draft October 2, 2024 14:26
@jmchilton jmchilton force-pushed the file_source_property_global_defaults branch 2 times, most recently from 34c1a3a to dfc194d Compare October 2, 2024 15:13
@jmchilton jmchilton force-pushed the file_source_property_global_defaults branch from dfc194d to ab70b5b Compare October 5, 2024 21:23
@jmchilton jmchilton marked this pull request as ready for review October 6, 2024 14:26
@mvdbeek mvdbeek merged commit 4c75803 into galaxyproject:dev Oct 7, 2024
53 of 55 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Oct 7, 2024

Thank you @jmchilton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants