-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting a few global defaults for file source plugin types. #18909
Allow setting a few global defaults for file source plugin types. #18909
Conversation
5849b06
to
1899eb1
Compare
I also fixed up and expanded some webdav tests. Directions are at the top of the test_webdav.py if you want to run them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much John!
I wouldn't expect we would add more configuration values to the config schema... I thought we were trying to avoid adding more, but I'm not an admin, so I'm not complaining 😝
You may need to run make config-rebuild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the nitpicking here ... I guess I would only insist on flipping the use_temp_files setting to true.
34c1a3a
to
dfc194d
Compare
dfc194d
to
ab70b5b
Compare
Thank you @jmchilton! |
The idea is we don't want users having to define the technical details of plugin specification that are related to the infrastructure of Galaxy and not the remote data source. Even allowing them in the templates is kind of heavy - so being able to just set them in Galaxy's config is sort of ideal.
Even outside the context of user defined file sources - I think this is kind of an important point. Take for example - https://github.com/galaxyproject/usegalaxy-playbook/blob/main/env/common/templates/galaxy/config/file_sources_conf.yml.j2 - it is very heavy and error prone that the "listings_expiry_time" parameter needs to be defined in each plugin.
How to test the changes?
(Select all options that apply)
License