Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type annotations and fixes #18911

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Type annotations and fixes #18911

merged 1 commit into from
Oct 1, 2024

Conversation

nsoranzo
Copy link
Member

Also:

  • Use galaxy.util.path.StrPath everywhere
  • Small refactorings.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo
Type annotations and fixes
136747e 
- Use `galaxy.util.path.StrPath` everywhere
@nsoranzo nsoranzo added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Sep 30, 2024
@github-actions github-actions bot added this to the 24.2 milestone Sep 30, 2024
@nsoranzo nsoranzo requested a review from a team October 1, 2024 09:39
davelopez
davelopez approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refactorings and type hints! Thank you!

lib/galaxy/datatypes/registry.py Show resolved Hide resolved
@nsoranzo nsoranzo merged commit 1224c65 into galaxyproject:dev Oct 1, 2024
54 of 55 checks passed
@nsoranzo nsoranzo deleted the type_annot_cwl branch October 1, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

@jmchilton jmchilton jmchilton approved these changes

Assignees
No one assigned
Labels
area/datatypes area/jobs area/testing area/tool-dependencies area/tool-framework area/util kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
3 participants
@nsoranzo @jmchilton @davelopez