Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow license and creator edit keyboard access #18936

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Oct 4, 2024

Closes #18915. This PR improves the LicenseSelector and CreatorEditor ui and makes them keyboard accessible. It migrates LicenseSelector to composition API and typescript, uses GalaxyAPI to fetch license options, and uses the MultiSelect component, simplifying the license handling steps.

Workflow.license.and.creator.edit.keyboard.access.mov

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. In the workflow editor, access and edit license and creator via keyboard

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@itisAliRH itisAliRH added kind/enhancement area/accessibility Specifically for a11y issues; screenreader issues, etc. labels Oct 4, 2024
@itisAliRH itisAliRH marked this pull request as ready for review October 5, 2024 14:18
@github-actions github-actions bot added this to the 24.2 milestone Oct 5, 2024
@mvdbeek
Copy link
Member

mvdbeek commented Oct 7, 2024

Can you also remove the save/cancel buttons ? We don't do that anywhere else in the editor

@itisAliRH
Copy link
Member Author

Can you also remove the save/cancel buttons ? We don't do that anywhere else in the editor

@mvdbeek The creator form is using it:
image
Should I remove buttons in both components or not? If yes, does replacing them with only small icons work?

@hexylena
Copy link
Member

hexylena commented Oct 9, 2024

oh those buttons are much nicer click targets than the absolutely miniscule 'save' icon that's currently used. Would be very happy to have those larger targets for my poor mouse aim (the reason I use the keyboard to start with)

@mvdbeek
Copy link
Member

mvdbeek commented Oct 10, 2024

Yeah, I think removing those save button would be great.

@dannon
Copy link
Member

dannon commented Oct 10, 2024

+1 to removing them and saving consistent with other workflow changes.

@itisAliRH
Copy link
Member Author

Thank you all for the comments. So I will remove the buttons and show only the licence selector on the editor.

…add error alert, improve button controls and make them accessible via keyboard
…lity

Updated the `LicenseSelector` component to enhance user experience by replace a `Multiselect` form `vue-multiselect` dropdown and simplifying the license handling steps and logic.
@itisAliRH itisAliRH force-pushed the workflow-license-creator-keyboard branch from 9925cc1 to 024bf21 Compare October 11, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/accessibility Specifically for a11y issues; screenreader issues, etc. area/UI-UX kind/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot access workflow license save button via keyboard only
4 participants