Fix extra files path type hint #18958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
added
kind/refactoring
nsoranzo
reviewed
Oct 9, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Otherwise is considered as None
Co-authored-by: Nicola Soranzo <[email protected]>
davelopez
force-pushed
the
fix_extra_files_path_type_hint
branch
from
2b70e05
to
422221d
Compare
|
Finally all green! Thank you @nsoranzo for all the CI fixes! |
nsoranzo
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detected by pylance while working on #17614
The type of
extra_files_pathwill resolve to Any/None otherwise. Fixing this revealed other typing issues downstream.How to test the changes?
License