Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Decoupling user email from role name #18966

Draft
wants to merge 18 commits into
base: dev
Choose a base branch
from
Draft

[WIP] Decoupling user email from role name #18966

wants to merge 18 commits into from

Commits on Oct 10, 2024

  1. Do not require private role name = user.email in tests

    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3f9ca2b View commit details
    Browse the repository at this point in the history

  2. Update remote user private role bug fix from 2009

    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b0194ff View commit details
    Browse the repository at this point in the history

  3. Remove breakpoint() comment

    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7ff2633 View commit details
    Browse the repository at this point in the history

  4. Factor out roles service from roles api

    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6349b38 View commit details
    Browse the repository at this point in the history

  5. Add users api endpoint for user-roles

    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d04327b View commit details
    Browse the repository at this point in the history

  6. Change how a populator gets a user's private role 

    Because we no longer can match role name to user email
    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b661670 View commit details
    Browse the repository at this point in the history

  7. Add API test for new user-roles endpoint

    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    347da39 View commit details
    Browse the repository at this point in the history

  8. Remove unique constraint from role name, add not null constraint

    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7f2c2a6 View commit details
    Browse the repository at this point in the history

  9. Add migration: remove unique constraint from role name, add not null … 

    …constraint
    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a83da4d View commit details
    Browse the repository at this point in the history

  10. Assign default role name based on role type 

    Now that role name doesn't have to be unique, we don't want to pass args
like "private role" or "shared role" on role creation.
    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8ee2719 View commit details
    Browse the repository at this point in the history

  11. Do not specify name when creating a sharing role

    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    bb199f8 View commit details
    Browse the repository at this point in the history

  12. Fix unit test: check for correct role name

    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5a3f7aa View commit details
    Browse the repository at this point in the history

  13. Do not use user's email in private role name, description 

    Reason: decouple user email from private role naming: emails can be
changed or redacted; user id in user-role-association + role type is
sufficient to tie a user to a private role.

The description (i.e., "this is a private role for a user" is inferrable
from the role name ("private role"), which is assigned by default.
    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    31c6e64 View commit details
    Browse the repository at this point in the history

  14. Modify make_role fixture to accommodate downgrading in migration tests

    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a5cef0c View commit details
    Browse the repository at this point in the history

  15. Fix grammar typo in schema

    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1ae35a8 View commit details
    Browse the repository at this point in the history

  16. Do not retrieve roles based on string matching 

    Reasons: not needed, query is ambiguos after decoupling user emails from role names
    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3ab63cc View commit details
    Browse the repository at this point in the history

  17. Fix set of role names 

    - Add user email to represent user's private role
- Exclude generic role names
    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    146a290 View commit details
    Browse the repository at this point in the history

  18. Rebuild client schema

    @jdavcs
    jdavcs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    84a30a2 View commit details
    Browse the repository at this point in the history