Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly display dataset preview in pages and workflow reports #18968

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Oct 10, 2024

When embedding certain datasets into pages and workflow reports, the dataset might not be properly displayed since the preview=True option is not specified.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 24.2 milestone Oct 10, 2024
@guerler guerler marked this pull request as ready for review October 10, 2024 06:57
@bgruening
Copy link
Member

Tested on EU and seems to work. ping @fubar2

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its a bug in 24.1, should target 24.1?

@fubar2
Copy link
Member

fubar2 commented Oct 10, 2024

@bgruening Both display and embed now work for jbrowse2 objects - thanks!
image

@jmchilton jmchilton merged commit 6ac5c4c into galaxyproject:dev Oct 10, 2024
33 checks passed
@jmchilton
Copy link
Member

Feel free to commit it directly to 24.1 given it is a bug fix that has been merged in another branch.

@itisAliRH itisAliRH deleted the fix_report_dataset_preview branch October 11, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants