Fix issue with generating slug for sharing

[arash77]

This pull request fixes an issue with generating a slug for sharing. The commit includes a patch that adds a check to ensure that the slug base is not empty, and if it is, it sets it to "unnamed". This resolves the problem with generating slugs for sharing and publishing when it is not alphanumeric. related to #18584

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[arash77]

Should I add types-python-slugify==8.0.2.20240310 ; python_version >= "3.8" and python_version < "3.13" into /lib/galaxy/dependencies/pinned-typecheck-requirements.txt to fix the Library stubs not installed error?

[nsoranzo]

Should I add types-python-slugify==8.0.2.20240310 ; python_version >= "3.8" and python_version < "3.13" into /lib/galaxy/dependencies/pinned-typecheck-requirements.txt to fix the Library stubs not installed error?

Can you please also modify pyproject.toml by adding python-slugify to the [tool.poetry.dependencies] section and types-python-slugify to the [tool.poetry.group.typecheck.dependencies] section?

[arash77]

Should I add a requirement into one of the test-requirements.txt to fix the Test Galaxy packages?

[nsoranzo]

Should I add a requirement into one of the test-requirements.txt to fix the Test Galaxy packages?

Sorry, forgot about that! You should add python-slugify to the [options] -> install_requires section of packages/app/setup.cfg . That's because this dependency is used in lib/galaxy/manages which ends up in the galaxy-app package as you can see from the packages/app/galaxy/managers symlink.
Happy to give you more details about how the modules are split in packages if you are interested.

[arash77]

Should I add a requirement into one of the test-requirements.txt to fix the Test Galaxy packages?

Sorry, forgot about that! You should add python-slugify to the [options] -> install_requires section of packages/app/setup.cfg . That's because this dependency is used in lib/galaxy/manages which ends up in the galaxy-app package as you can see from the packages/app/galaxy/managers symlink. Happy to give you more details about how the modules are split in packages if you are interested.

Thank you for the explanation! I’d love to know more.

[nsoranzo]

Thank you for the explanation! I’d love to know more.

Some info is in this presentation, slides 65-72:

https://training.galaxyproject.org/training-material/topics/dev/tutorials/architecture/slides.html#65

Ping me on Matrix if you need clarifications.

[arash77]

The test failures seems to be irrelevant.

[mvdbeek]

Can you assert the actual slug?

[arash77]

The SharingStatus model doesn't have the slug itself.
Should I split it from this one?

[arash77]

like this:

Suggested change

	assert response["username_and_slug"]
	assert response["username_and_slug"].split("h/")[1] == history_name

[davelopez]

You can also assert that the history_name is in response["username_and_slug"], whatever you prefer