Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix extra call to test_data_path that requires an admin key #19011

Conversation

jmchilton
Copy link
Member

Regression introduced by @natefoo when he let 4a47efa get merged in without even reviewing it and catching this.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
  • Run a tool test as a non-admin user against test.galaxyproject.org with and without this change.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez
Copy link
Contributor

I knew it was @natefoo fault! 😅

@natefoo
Copy link
Member

natefoo commented Oct 16, 2024

I'm so careless.

@jmchilton jmchilton marked this pull request as ready for review October 16, 2024 19:18
@github-actions github-actions bot added this to the 24.1 milestone Oct 16, 2024
@jmchilton jmchilton merged commit 666ab5e into galaxyproject:release_24.1 Oct 17, 2024
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants