Yet More Vue Typing Error Fixes

[jmchilton]

@davelopez has done a lot of review of #19663 so I thought I would cleanup that branch and rebase it until those fixes are ready and open a new PR with the next set of fixes on top of those.

How to test the changes?

(Select all options that apply)

• This is a refactoring of components with existing test coverage.

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[jmchilton]

Current errors: 13
Baseline errors: 82

I think after this PR all the remaining errors have an issue or a PR. Here are the 13 and links.

src/components/DatasetInformation/DatasetErrorDetails.vue:31:24 - error TS18046: 'jobMessage' is of type 'unknown'.

#19688

src/components/DatasetInformation/DatasetInformation.vue:131:42 - error TS2322: Type '{ extra_files_path?: string | null | undefined; id: string; source_uri: string; transform?: unknown[] | null | undefined; }[]' is not assignable to type '{ source_uri: string; transform: DatasetTransform[]; }[]'.

#19666

src/components/Form/Elements/FormData/FormData.vue:705:13 - error TS2322: Type 'DataOption[] | undefined' is not assignable to type 'null | undefined'.

#19668

src/components/Form/FormElement.vue:264:18 - error TS1117: An object literal cannot have multiple properties with the same name.

src/components/Form/FormElement.vue:279:18 - error TS1117: An object literal cannot have multiple properties with the same name.

src/components/Form/FormElement.vue:303:18 - error TS1117: An object literal cannot have multiple properties with the same name.

src/components/History/Modals/CopyModal.vue:122:52 - error TS1117: An object literal cannot have multiple properties with the same name.

src/components/History/Modals/CopyModal.vue:126:52 - error TS1117: An object literal cannot have multiple properties with the same name.

src/components/User/DiskUsage/Management/Cleanup/ReviewCleanupDialog.vue:232:98 - error TS1117: An object literal cannot have multiple properties with the same name.

#19670

src/components/Form/FormElement.vue:316:18 - error TS2322: Type '"upload" | "text" | "data" | "select" | "tags" | "color" | "hidden" | "password" | "data_collection" | "rules" | "hidden_data" | "baseurl" | "radio" | "directory_uri" | "data_column" | ... 4 more ... | undefined' is not assignable to type '"data" | "data_collection" | undefined'.
Type '"upload"' is not assignable to type '"data" | "data_collection" | undefined'.

#19691

src/components/Markdown/MarkdownDialog.vue:268:14 - error TS2322: Type '(response: string) => void' is not assignable to type '(results: SelectionItem[]) => void'.
Types of parameters 'response' and 'results' are incompatible.
Type 'SelectionItem[]' is not assignable to type 'string'.

#19692

src/components/Workflow/List/WorkflowCardList.vue:87:14 - error TS2740: Type 'Workflow' is missing the following properties from type '{ annotation: string | null; annotations?: string[] | null | undefined; create_time: string; creator?: ({ address?: string | null | undefined; alternateName?: string | null | undefined; ... 12 more ...; url?: string | ... 1 more ... | undefined; } | { ...; })[] | null | undefined; ... 21 more ...; version: number; }': annotation, create_time, creator_deleted, deleted, and 16 more.

src/components/Workflow/List/WorkflowList.vue:481:18 - error TS2322: Type '(w: SelectedWorkflow) => void' is not assignable to type '(workflow: Workflow) => void'.

#19681

[davelopez]

Awesome! Thank you so much!

@dannon mentioned he wanted to check something during the meeting, otherwise, I think it is ready to merge.

[dannon]

@davelopez thanks for the review; looking now. The thing I wanted to track down was that I thought I saw a loosening of something to undefined | null where it was just null previously but I'm not seeing it now -- maybe it got rebased out?

I'll give the rest a quick look. Thanks again for the dedication to this @jmchilton

[jmchilton]

@dannon Possible - I took a couple different stabs at hardening the object store selection typing - sort of get it working and then get it right approach. It was probably in there.