Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix test_mulled_build.py::test_mulled_build_files_cli with use_mamba=True" #19712

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Feb 27, 2025

Reverts #19545 because it breaks container building since the install location must be the same as the location in the final image (conda environments can not be relocated .. we are just using here that the install location and the location in the final image is the same).

I can't see that the unit test that should be fixed in the referred PR actually ran.

Needs to be backported to 24.0 #19626.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@kysrpex
Copy link
Contributor

kysrpex commented Feb 27, 2025

I cannot check this soonish, bit if ir breaks container builds go ahead, broken containers are worse than broken tests

determining base image is not needed, but takes most of the time
@bernt-matthias
Copy link
Contributor Author

1974681 should fix the unit test temporarily (until the miniforge container contains mamba>=2.0). mamba-org/mamba#3845

Copy link
Member

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this, nice fix!

@martenson
Copy link
Member

as I understand it this is not needed since #19714 will be merged forward, please reopen if I'm wrong

@martenson martenson closed this Feb 28, 2025
@nsoranzo
Copy link
Member

Commit 7a4a565 is not part of #19714, reopening.

@bernt-matthias Do you want to rebase it?

@nsoranzo nsoranzo reopened this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants