-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fix test_mulled_build.py::test_mulled_build_files_cli
with use_mamba=True
"
#19712
base: dev
Are you sure you want to change the base?
Conversation
…`use_mamba=True`" This reverts commit 9a0a58b.
I cannot check this soonish, bit if ir breaks container builds go ahead, broken containers are worse than broken tests |
determining base image is not needed, but takes most of the time
1974681 should fix the unit test temporarily (until the miniforge container contains mamba>=2.0). mamba-org/mamba#3845 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for investigating this, nice fix!
as I understand it this is not needed since #19714 will be merged forward, please reopen if I'm wrong |
Commit 7a4a565 is not part of #19714, reopening. @bernt-matthias Do you want to rebase it? |
Reverts #19545 because it breaks container building since the install location must be the same as the location in the final image (conda environments can not be relocated .. we are just using here that the install location and the location in the final image is the same).
I can't see that the unit test that should be fixed in the referred PR actually ran.
Needs to be backported to 24.0 #19626.
How to test the changes?
(Select all options that apply)
License