-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ToolShed 2.0] Replace Infinite Scrolling GQL with Rest+Pagination #19722
Draft
jmchilton
wants to merge
18
commits into
galaxyproject:dev
Choose a base branch
from
jmchilton:toolshed_2_simplified
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,030
−4,896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously documented in a PR note - galaxyproject#15639.
fd338f5
to
dc6c809
Compare
I've implemented some more hardening also. I've refined the changing password story a bit - there is some actual end-user feedback now when things go correctly. I also implemented some simple rate limiting on sensitive APIs using slowapi. We don't monitor these services as closely so I think this is probably important. |
dc6c809
to
4b4e232
Compare
e2a38b5
to
920ae8f
Compare
…tly created widget.
Dropping the odd skip_fille parameter. I don't know... that this is a good idea but it was requested and it landed in the Tool Shed 2.1 issue (xref galaxyproject#18652).
920ae8f
to
cb7ea36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All sorts of odd little breaking happens with the infinite scrolling grid and potentially with GQL. This is much more straight-forward now. The paradigm is more familiar and the static nature should make the UI much more robust. This required all sorts of updates to the index endpoint but I caught some bugs and added a bunch of test coverage and generally feel good about all those endpoint updates.
I also removed the recently updated repositories widget. The update times I think are correct from the database - but I have no clue what the database is actually tracking. Maybe each download is an update? Anyway - GQL is now just used for the recently recently created listings now - a pretty small component.
There was a bunch of whitespace on the landing page caused by removing the recently updated repositories. I've replaced this with a little help carousel and some context about what the tool shed is. I reused the help in the actual help page so that is more filled in now also.
Before:
After:

How to test the changes?
(Select all options that apply)
License