Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ToolShed 2.0] Replace Infinite Scrolling GQL with Rest+Pagination #19722

Draft
wants to merge 18 commits into
base: dev
Choose a base branch
from

Conversation

jmchilton
Copy link
Member

All sorts of odd little breaking happens with the infinite scrolling grid and potentially with GQL. This is much more straight-forward now. The paradigm is more familiar and the static nature should make the UI much more robust. This required all sorts of updates to the index endpoint but I caught some bugs and added a bunch of test coverage and generally feel good about all those endpoint updates.

I also removed the recently updated repositories widget. The update times I think are correct from the database - but I have no clue what the database is actually tracking. Maybe each download is an update? Anyway - GQL is now just used for the recently recently created listings now - a pretty small component.

There was a bunch of whitespace on the landing page caused by removing the recently updated repositories. I've replaced this with a little help carousel and some context about what the tool shed is. I reused the help in the actual help page so that is more filled in now also.

Before:

Screenshot 2025-02-28 at 8 37 22 AM

After:
Screenshot 2025-02-28 at 8 34 26 AM

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton
Copy link
Member Author

I've implemented some more hardening also. I've refined the changing password story a bit - there is some actual end-user feedback now when things go correctly. I also implemented some simple rate limiting on sensitive APIs using slowapi. We don't monitor these services as closely so I think this is probably important.

@jmchilton jmchilton force-pushed the toolshed_2_simplified branch from dc6c809 to 4b4e232 Compare February 28, 2025 18:00
@jmchilton jmchilton force-pushed the toolshed_2_simplified branch 2 times, most recently from e2a38b5 to 920ae8f Compare February 28, 2025 19:24
@jmchilton jmchilton force-pushed the toolshed_2_simplified branch from 920ae8f to cb7ea36 Compare February 28, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant